Skip to content

feat: add kerberos authentication provider #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 30, 2024
Merged

feat: add kerberos authentication provider #880

merged 8 commits into from
Sep 30, 2024

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Sep 27, 2024 •
edited
Loading

Description

Required for stackabletech/kafka-operator#762

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] ~CRD changes approved.~ None.
- [x] Integration tests passed (for non trivial changes). Yes, tested with Kafka/Kerberos.

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@adwk67 adwk67 changed the title feat: add kerberos authentication provider chore: add kerberos authentication provider Sep 27, 2024
@adwk67 adwk67 marked this pull request as ready for review September 27, 2024 09:12
@adwk67 adwk67 self-assigned this Sep 27, 2024
@adwk67 adwk67 requested a review from a team September 27, 2024 09:15
@adwk67 adwk67 changed the title chore: add kerberos authentication provider feat: add kerberos authentication provider Sep 27, 2024
sbernauer
sbernauer requested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only nits. I think we should also move this through a CRD decision, as the Kafka Kerberos decision did only contain the KafkaCluster but not the new AuthenticationClass

adwk67 and others added 4 commits September 27, 2024 11:36
@adwk67 @sbernauer
Update crates/stackable-operator/src/commons/authentication/kerberos.rs
f0c5fad 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@adwk67 @sbernauer
Update crates/stackable-operator/src/commons/authentication/mod.rs
6b3abf9 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@adwk67
formatting
5c1ba67
@adwk67
added docs link
03cd3f2
@adwk67 adwk67 linked an issue Sep 27, 2024 that may be closed by this pull request
Support Kerberos authentication in Kafka stackabletech/kafka-operator#655
Closed
@adwk67 adwk67 mentioned this pull request Sep 27, 2024
Merged
15 tasks
sbernauer
sbernauer requested changes Sep 30, 2024
View reviewed changes
@adwk67 @sbernauer
Update crates/stackable-operator/src/commons/authentication/kerberos.rs
2e9f994 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@adwk67 adwk67 requested a review from sbernauer September 30, 2024 07:21
@adwk67 adwk67 added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 57c401c Sep 30, 2024
10 checks passed
@adwk67 adwk67 deleted the chore/add-kerberos-auth-prov branch September 30, 2024 08:06
@adwk67 adwk67 mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@adwk67 adwk67

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Kerberos authentication in Kafka
2 participants
@adwk67 @sbernauer